I agree on removing unnecessary trailing white-space, but final new lines are a good practice on git so if you append, it will not rewrite the last line (adding the "new line character").

@fcolecumberri

Hi, By Remove trailing final new lines I mean that files that ended with two blank lines I have removed only one of them.

Hello @PovilasKorop

Edit: See comment below: #145 (comment)
@AhmedAlaa4611 Multiple files appear to have their final trailing newline removed. It is good practice to keep the trailing newline in place.

Files that appear to have their final trailing newline removed in this PR:

• collections.md
• factories.md
• mail.md
• migrations.md
• model-relations.md
• other.md
• routing.md
• validation.md
• views.md

I recommend restoring these entries.
The rest of the PR appears to be removing unneeded whitespace from the end of some lines and looks like it would be a good contribution.

Hello, @KeithBush these files currently end with two blank lines at the end of the file, I have removed only one of them. If you try to edit any of these files you will see that they have two blank lines at the end, not just one.

Github is not showing the final newline for me but I pulled you code and see it in place and pulled this repo and see the duplicates you removed in your PR. I guess I never noticed that the final new lines were hidden until now (or I somehow turned that on in github by accident).

In any case, I retract my earlier recommendation and confirm this looks clean to me. 👍

To be honest, I'm not in active support of this repository anymore, I've switched to sharing my tips on Twitter and YouTube and other social networks.

I think this GitHub repository is not the most convenient way to consume those tips, as no one would actually go and read those hundreds of tips in one page.

But sure if you think it's valuable and you think that pull request is valuable to others, I'm happy to merge it.